Why my ObservableObject seems to be broken with a specific view? - class

Question

I have created a class for keeping the trace a the actual view (a simple ObservableObject String) :
import Foundation
import SwiftUI
import Combine
class ViewRouter: ObservableObject {
#Published var currentView: String
init() {
self.currentView = "Home"
}
}
I have create a simple custom TabView and it works very well with this :
import SwiftUI
struct Test2CustomTabView: View {
#ObservedObject var viewRouter = ViewRouter()
var body: some View {
GeometryReader { geometry in
VStack {
Spacer()
if self.viewRouter.currentView == "Home" {
Home()
} else if self.viewRouter.currentView == "Messages" {
Messages()
}
Spacer()
HStack {
VStack {
Image(systemName: "house")
Text("Home")
.font(.caption)
}.frame(width: geometry.size.width/2, alignment: .center)
.offset(y: -15)
.onTapGesture {
self.viewRouter.currentView = "Home"
}
VStack {
Image(systemName: "envelope")
Text("Messages")
.font(.caption)
}.frame(width: geometry.size.width/2, alignment: .center)
.offset(y: -15)
.onTapGesture {
self.viewRouter.currentView = "Messages"
}
}.frame(height: 85)
.foregroundColor(.white)
.background(Color(#colorLiteral(red: 0.259467423, green: 0.5342320204, blue: 0.7349982858, alpha: 1))) // On utilise ici extension Color plus bas
}
}
.edgesIgnoringSafeArea(.bottom)
}
}
I want to simplify the code so i created this view :
import SwiftUI
struct Test2CustomTabViewItem: View {
#ObservedObject var viewRouter = ViewRouter()
var systemName:String
var viewName:String
let screenSize: CGRect = UIScreen.main.bounds
var body: some View {
VStack {
Image(systemName: systemName)
Text("Home")
.font(.caption)
}.frame(width: screenSize.width/2, alignment: .center)
.offset(y: -15)
.onTapGesture {
self.viewRouter.currentView = self.viewName
}
}
}
struct Test2CustomTabViewItem_Previews: PreviewProvider {
static var previews: some View {
Test2CustomTabViewItem(systemName: "house", viewName: "Home")
}
}
And now im using the Test2CustomTabView like this :
import SwiftUI
struct Test2CustomTabView: View {
#ObservedObject var viewRouter = ViewRouter()
var body: some View {
GeometryReader { geometry in
VStack {
Spacer()
if self.viewRouter.currentView == "Home" {
Home()
} else if self.viewRouter.currentView == "Messages" {
Messages()
}
Spacer()
HStack {
Test2CustomTabViewItem(systemName: "house", viewName: "Home")
Test2CustomTabViewItem(systemName: "envelope", viewName: "Messages")
}.frame(height: 85)
.foregroundColor(.white)
.background(Color(#colorLiteral(red: 0.259467423, green: 0.5342320204, blue: 0.7349982858, alpha: 1))) // On utilise ici extension Color plus bas
}
}
.edgesIgnoringSafeArea(.bottom)
}
}
struct Test2CustomTabView_Previews: PreviewProvider {
static var previews: some View {
Test2CustomTabView()
}
}
But now when i click on the custom tabview item the view are not refreshed, the change in the ObservableObject doesn't refresh the view and i dont understand why..
Any idea?
Thanks

Answer 1

In your code each view has his own ViewRouter instance. Pass it to Test2CustomTabViewItem view from the constructor or as environmentObject:
struct Test2CustomTabViewItem: View {
#ObservedObject var viewRouter: ViewRouter
var systemName:String
var viewName:String
...
}
struct Test2CustomTabView: View {
#ObservedObject var viewRouter = ViewRouter()
...
Test2CustomTabViewItem(viewRouter: self.viewRouter, systemName: "house", viewName: "Home")
Test2CustomTabViewItem(viewRouter: self.viewRouter, systemName: "envelope", viewName: "Messages")
...
}