iOS - Why my NSURL isn't retained in the init method? - iphone

Question

I'm creating a new UIViewController with 2 properties :
#property (retain, nonatomic) NSURL *url;
#property (retain, nonatomic) NSString *title;
and synthetised :
#synthesize url = _url;
#synthesize title = _title;
in my custom init method i'm not using the setter like the Memory Management Guide says but when I need to use the properties in the viewDidLoad, the url seems empty, the title doesn't
- (id)initWithURL:(NSURL *)url andTitle:(NSString *)titleTemp
{
self = [super initWithNibName:#"navigatorViewController" bundle:nil];
if (self) {
_url = url;
_title = titleTemp;
}
return self;
}
- (void)viewDidLoad
{
[super viewDidLoad];
// Do any additional setup after loading the view from its nib.
[_titreBarButtonItem setTitle:_title];
NSURLRequest *urlRequest = [[NSURLRequest alloc] initWithURL:_url];
[_webView loadRequest:urlRequest];
[urlRequest release];
}
I can see my title but my web view is blank.
If I use self.url in the init, it's working !
Do you have an idea ?
PS : Here's how I call my init :
NSString *urlString = [[[NSBundle mainBundle] pathForResource:#"infos" ofType:#"html"] copy];
NSURL *url = [[NSURL alloc] initFileURLWithPath:urlString];
[urlString release];
navigatorViewController *navigatorVC = [[navigatorViewController alloc] initWithURL:url andTitle:#"Infos"];
[url release];
[self presentViewController:navigatorVC animated:YES completion:nil];
[navigatorVC release];
Thanks a lot

Answer 1

you are setting up the properties as retain, but this only applies if you use the synthesized getters. By setting the value directly on the ivar, you are bypassing this and the value is not being retained
you should be doing (probably not a great way when you already have setters):
_url = [url retain];
or better:
self.url = url;
or even better as matt said in the comments: use ARC

Answer 2

You must retain the URL either using :
self.url = url;
in the init method or call the retain after assigning the url in the init method like this.
_url = url;
[_url retain];

Answer 3

You need to add a reference (for what you hold) using copy or retain:
_url = [url copy];
_title = [titleTemp copy];
or
_url = [url retain];
_title = [titleTemp retain];

Answer 4

Well if you write a custom init method you need to do the retain your self:
- (id)initWithURL:(NSURL *)url andTitle:(NSString *)titleTemp
{
self = [super initWithNibName:#"navigatorViewController" bundle:nil];
if (self) {
_url = [url retain];
_title = [titleTemp retain];
}
return self;
}
That it worked with title is just that the variable is probably released later then the NSURL passes in the init method.