Why isn't my pack() packing my data? - perl

Question

What I am trying to do is simple. Here below.
my #arr = split(/\s+/,"50 00 9F 11 00 28 82 48 21 84 BC 00 01 02 01 00 09 01 38 00 23 05 08 01 01 02 00 00 18 00 50 05 00 00 00 00 00 00 00 00 02 00 0C FE CE 00 0F 00 FD FF 2D 00 00 00 00 00 04 01 0C FE");
my #hexData;
my $i=0;
foreach my $elem(#arr){
$hexData[$i]=hex($elem);
$i++;
}
my $data= pack ('C', #hexData);
print $data;
And its not working :( Would you please help?

Answer 1

TLP's solution is quite right, but pack actually has the ability to deal with hex.
my $data = "50 00 9F 11 00 28 82 48 21 84 BC 00 01 02 01 00 09 01 38 00 23 05 08 01 01 02 00 00 18 00 50 05 00 00 00 00 00 00 00 00 02 00 0C FE CE 00 0F 00 FD FF 2D 00 00 00 00 00 04 01 0C FE";
$data =~ tr/ //d; # Remove the spaces
print pack "H*", $data;
does the whole thing without the intermediate array.

Answer 2

I'm not terribly familiar with the pack function, but it seems to me that your template expects only one value.
Perhaps you should try
my $data = pack ('C*', #hexData);
And while you are at it, upgrade your code to something more perlish:
my #arr = qw(50 00 9F 11 00 28 82 48 21 84 BC 00 01 02 01 00 09 01 38 00 23 05
08 01 01 02 00 00 18 00 50 05 00 00 00 00 00 00 00 00 02 00 0C FE
CE 00 0F 00 FD FF 2D 00 00 00 00 00 04 01 0C FE);
my #hexData;
foreach my $elem (#arr) {
push #hexData, hex($elem);
}
my $data = pack ('C*', #hexData);
print $data;
Or even:
my $data = pack("C*", map(hex, #arr));