JPA criteria api order by query for #EmbeddedId - jpa

Question

I have 2 classes:
#Entity
#Table(name = "DRCOMMENTS" ,schema = "XXX")
#XmlRootElement
#NamedQueries({
#NamedQuery(name = "Drcomments.findAll", query = "SELECT d FROM Drcomments d"),
public class Drcomments implements Serializable {
private static final long serialVersionUID = 1L;
#EmbeddedId
protected DrcommentsPK drcommentsPK;
#Size(max = 50)
#Column(name = "SDESC")
private String commentSecondaryCodeDescription;
}
#Embeddable
public class DrcommentsPK implements Serializable {
#Column(name = "CODE")
private Short commentPrimaryCode;
#NotNull
#Column(name = "SCODE" , length=5)
private Short commentSecondaryCode;
}
I'm trying to create a query with a dynamic order by and a parameter, for example:
I want to select all Drcomments records when DrcommentsPK.commentPrimaryCode equels 1, and the order by will be by DrcommentsPK.commentSecondaryCode. this is what i tried:
CriteriaBuilder cb = em.getCriteriaBuilder();
CriteriaQuery<Drcomments> q = cb.createQuery(Drcomments.class);
Root<Drcomments> c = q.from(Drcomments.class);
q.select(c);
q.where(cb.equal(c.get("drcommentsPK").get("commentPrimaryCode"), 1));
Path<Drcomments> valuePath = c.get("drcommentsPK").get("commentSecondaryCode");
Order[] orders;
if(sord.equals("desc"))
{
orders = new Order[] {cb.desc(valuePath)};
}
else
{
orders = new Order[] {cb.asc(valuePath)};
}
q.orderBy(orders);
query = em.createQuery(q);
query.setFirstResult(start);
query.setMaxResults(start + limit);
results = query.getResultList();
The problem is that the resultlist I get is not sorted in the commentSecondaryCode desc order..
am I doing somthing wrong? how can this be done? how to create a query that will be ordered by a field inside the emeddable class?
UPDATE:
this is the generated sql I get:
SELECT * FROM
(SELECT * FROM
(SELECT EL_TEMP.*, ROWNUMBER() OVER() AS EL_ROWNM FROM
(SELECT CMSSDESC AS a1, CMSSCODE AS a4, CMSPCODE AS a5 FROM DRCOMMENTS
WHERE (CMSPCODE = 1) ORDER BY CMSSCODE DESC, CMSPCODE DESC)
AS EL_TEMP)
AS EL_TEMP2 WHERE EL_ROWNM <= 50)
AS EL_TEMP3 WHERE EL_ROWNM > 0
when I run this code it wont return the records in the CMSSCODE desc order..
(beacuse the order by should be in the outer select..)
do I need to change somthing in the query.setFirstResult() and query.setMaxResults() ?
I how do I add it to the end in the criteria query, so it will be in the last select?
Thank's In Advance.

Answer 1

Your code is fine and standard compliant. If you are sure it doesn't work, then there must be bug in implementation or some odd stuff in those parts of code that is not shown. For example, check that value of sord is exactly "desc" (case sensitive), because otherwise you will fall to use ascending order.
I tried it with Hibernate 3.6.8.Final and EclipseLink (2.3.2). With both of them it works as expected - ORDER BY SCODE [ASC/DESC] is part of the executed SQL query.