SubViews not getting removed - iphone

Question

Can someone tell me why this code isn't removing the subview that's being animated? The views are stacking up and the second time I dismiss the view, it won't animate and there are now two instances of subView with tag 99. It wasn't released the first time.
for (UIView *subview in [self.smallView subviews]) {
NSLog(#"view:%#",subview);
if (subview.tag == 99) {
[UIView animateWithDuration:.5
animations:^{
subview.alpha = 0;
}
completion:^(BOOL finished){
subview.alpha = 0;
[subview removeFromSuperview];
}];
}
}
Here's how I add the subview, viewVC is a ViewController Subclass and smallView is where I add my map and is the container for all the views.
#property (nonatomic, retain) CustomViewController *viewVC;
viewVC = [self.storyboard instantiateViewControllerWithIdentifier:#"VIEWVC"];
viewVC.view.frame = CGRectMake(20, 20, 280, 371);
viewVC.view.layer.cornerRadius = 15;
viewVC.view.tag = 99;
viewVC.view.alpha = 0;
[self.smallView addSubview:viewVC.view];
[UIView animateWithDuration:.5
animations:^{
viewVC.view.alpha = 1;
}
completion:^(BOOL finished){
viewVC.view.alpha = 1;
}];

Answer 1

I think the problem might be that you're removing an object from the array you're iterating through, which will cause problems. Try this:
NSArray *subviews = [NSArray arrayWithArray:[self.smallView subviews]];
for (UIView *subview in subviews) {
NSLog(#"view:%#",subview);
if (subview.tag == 99) {
[UIView animateWithDuration:.5
animations:^{
subview.alpha = 0;
}
completion:^(BOOL finished){
subview.alpha = 0;
[subview removeFromSuperview];
}];
}
}
This way, you are no longer removing an object from the array you are iterating through.

Answer 2

Could you please clarify why you are checking for the value of subview.tag to be 99? Is it at all possible that the code in the if statement isn't getting called at all? Throw in some NSLog calls, and see if your code within that if statement is even executing. If it is, then you should check out the methods that you are invoking within the if statement and make sure that they are all okay.