Why does script stop working and need to be reloaded? - autohotkey

Question

I have a script that I use to open Firefox that contains customized shortcuts and that closes when I close the browser. Lately when I first open it and try to use a shortcut, it does not work until I reload the script, even though the script is still running. I haven't changed anything in the script in a while. Can anyone tell me what's going on?
Thanks,
Ellen
Menu, Tray, Icon, C:\Program Files\Mozilla Firefox\firefox.exe
SetTitleMatchMode, 2
runwait C:\Program Files\Mozilla Firefox\firefox.exe, , max
IfWinExist ahk_class MozillaWindowClass
Return
ExitApp
Return
#SingleInstance Force
#installKeybdHook
#Persistent
Return
#ifWinActive Mozilla Firefox
^!b::send, ^+b
^b::send, ^d ; bookmark page]
^n::send, ^t ; open new tab
!c::send, ^w ; close current tab
^d::send, ^!t ; duplicate tab
^u::send, ^+t ; undo close tab
!d::send, ^j ; open downloads
^e::
MouseClick, left, 33, 44
Sleep, 100
MouseClick, left, 33, 230
Sleep, 100
return
^r:: ; recent pages
MouseClick, left, 79, 76
return
!a:: ; click on address bar
MouseClick, left, 368, 73
return
^q:: ; roboform
MouseClick, left, 864, 722
return
^BS::send, +{Backspace} ; forward
Up::send, ^{+} ;zoom in
Down::send, ^{-} ;zoom in
::abc::about:config
#ifWinActive

Answer 1

To me the problem with your script seems to be that the runwait makes the script stop the the current thread that is running firefox.
That thread then waits for firefox to close giving you the "STILL WAITING"... then when it closes the next line is IfWinExist ahk_class MozillaWindowClass and it will not exist making the script skip to Exitapp
While RunWait is in a waiting state, new threads can be launched via hotkey, custom menu item, or timer.
When using RunWait some programs will appear to return immediately even though they are still running, these programs spawn another process. With the way your script is setup it may stop RunWait from going into this waiting state once in a while.
And this will make you unable to launch new threads as autohotkey is not multi threaded...
So I say use something like WinWaitClose as that will also let you launch new threads
While WinWaitClose is in a waiting state, new threads can be launched via hotkey, custom menu item, or timer.
Something like this:
Run, C:\Program Files\Mozilla Firefox\firefox.exe, , max
WinWait, ahk_class MozillaWindowClass
WinWaitClose ; Wait for the exact window found by WinWait to be closed.
Exitapp
Hope it helps