Unknown error in Dynamic String Handling in a T-SQL Environment. PS: I am not going to do any conversions. Just want to create an Update statement and execute it later
Code:
DROP TABLE IF EXISTS #TEMP
Select 'CRDB_Reporting' tablename,'MagnitudePackage' updatecolumn,'String' updatecolumntype,'''XLFWH''' updatevalue,'NatureOfFundCode' primaryfilter,'String' primaryfiltertype,'''FWH''' primaryfiltervalue,NULL remainingfilter
INTO #TEMP
Select
CASE
WHEN remainingfilter IS NOT NULL THEN
'Update [dbo].[' + tablename +'] Set [' + updatecolumn +'] = ' + updatevalue + ' Where [' + primaryfilter +'] = ' + primaryfiltervalue + ' And ' + remainingfilter
WHEN remainingfilter IS NULL THEN
'Update [dbo].[' + tablename +'] Set [' + updatecolumn +'] = ' + updatevalue + ' Where [' + primaryfilter +'] = ' + primaryfiltervalue + ' And '
END
From #Temp
Expected Result
Update [dbo].[CRDB_Reporting] Set [MagnitudePackage] = 'XLFWH' Where [NatureOfFundCode] = 'FWH'
Error Msg:
Msg 245, Level 16, State 1, Line 34 Conversion failed when converting
the varchar value 'Update [dbo].[CRDB_Reporting] Set
[MagnitudePackage] = 'XLFWH' Where [NatureOfFundCode] = 'FWH' And '
to data type int.
When you are creating the column remainingfilter it has an implicit conversion of int
So to fix that, use ...,cast(NULL as varchar(max)) remainingfilter
That said, I would opt for concat()
Example
Select Cmd = concat('Update ',quotename(tablename),' set ',quotename(updatecolumn),' = ',updatevalue,' And ' + nullif(remainingfilter,''))
From #Temp
Returns
Update [CRDB_Reporting] set [MagnitudePackage] = 'XLFWH'
This is real weird.
when I trace through this code, on the first statement, I am getting #str as a valid insert statement when it is coded as a single line, but when I set #str through select statement, accross multiple lines, it holds value of nothing.
Its really flakey, because some of my inserts worked, and some didn't.
Any ideas how to set the variable properly across multiple lines? Or is this a Microsoft bug...?
UPDATE: Same thing happens when I edit the multi-line t-sql Select into a one line statement
#str, when tracing the code, often turns out to be blank, when it seems like it should not be blank...(the second instance of #str...
Select #str = 'Insert into CustShip Values (' + '''' + #A_Cust_No + '''' + ', ' + '''' + #Ship_To_Id + '''' + ',3)'
EXEC(#str)
Select #str = 'Insert into ShipTo Values ....'
This Second #str is often evaluated to blank....)
ALTER Procedure [dbo].[RefreshCustShip3]
AS
Begin /* Begin Proc */
Set NoCount On
--Delete from CustShip
DECLARE #SHIP_TO_NAME VarChar(255),
#A_Cust_No varchar(255),
#SHIP_TO_ADD1 VarChar(255),
#SHIP_TO_ADD2 VarChar(255),
#SHIP_TO_ADD3 VarChar(255),
#CITY VarChar(255),
#STAT VarChar(255),
#ZIP_Code VarChar(255),
#SHIP_TO_ID VarChar(255),
#COUNTRY VarChar(255),
#ShipId varchar(255),
#str varchar(1000)
DECLARE C CURSOR FAST_FORWARD /* read only, forward only */ FOR
SELECT
A#CUST#NO,
CUST#NAME as SHIP#TO#NAME,
SOLD#TO#ADD#1 AS SHIP#TO#ADD#1,
SOLD#TO#ADD#2 AS SHIP#TO#ADD2,
SOLD#TO#ADD#3 AS SHIP#TO#ADD3,
SOLD#TO#CITY AS CITY,
SOLD#TO#STATE AS [STATE],
SOLD#TO#ZIP#CODE AS ZIP#CODE,
CONCAT(LTRIM(RTRIM(A#CUST#NO)), LTRIM(RTRIM(SOLD#TO#ADD#1))) AS SHIP#TO#ID,
COUNTRY#NAME as Country
from Cust left join CustShip on
Cust.A#Cust#No = CustShip.CustNo
WHERE CustShip.ShipToID is Null
OPEN C
FETCH NEXT FROM C INTO #A_Cust_No, #Ship_To_Name, #SHIP_TO_ADD1, #SHIP_TO_ADD2, #SHIP_TO_ADD3, #CITY, #STAT, #ZIP_Code, #SHIP_TO_ID, #Country;
WHILE ##FETCH_STATUS = 0
BEGIN
if #A_Cust_No = '3RGHOU'
begin
print #Ship_To_Id
end
-- do work here BEGIN CODE BLOCK
Select #str = 'Insert into CustShip Values (' + '''' + #A_Cust_No + '''' + ', ' + '''' + #Ship_To_Id + '''' + ',3)'
EXEC(#str)
Select #str = 'Insert into ShipTo Values (' + '''' + #A_Cust_No + '''' + ', '
+ '''' + #Ship_To_Name + '''' + ', '
+ '''' + #Ship_To_Add1 + '''' + ', '
+ '''' + #Ship_To_Add2 + '''' + ', '
+ '''' + #Ship_To_Add3 + '''' + ', '
+ '''' + #City + '''' + ', '
+ '''' + #Stat + '''' + ', '
+ '''' + #ZIP_Code + '''' + ', '
+ '''' + #Ship_To_Id + '''' + ', '
+ '''' + #Country + ''''
+ ',3)'
EXEC(#str)
FETCH NEXT FROM C INTO #A_Cust_No, #Ship_To_Name, #SHIP_TO_ADD1, #SHIP_TO_ADD2, #SHIP_TO_ADD3, #CITY, #STAT, #ZIP_Code, #SHIP_TO_ID, #Country;
End
CLOSE C;
DEALLOCATE C;
End /* End Proc */
GO
I'm thinking out loud here. From looking at your SQL, Is there a possibility that you're running past your limit of VARCHAR(1000) on #Str? You're creating a string that has 10 variables that each could contain 255 characters. That is a total of 2550 characters without your insert statement syntax.
Also, since you're just assign that string to a single variable you should use SET instead of SELECT.
Also, put a semicolon statement terminator after the end of the string before the EXEC statement.
Also as HABO said above a null value in any of those variables would null out the entire string. Coalesce or doing ISNULL(#CITY, '') would fix that.
I think this is best answer, though many thanks to other posters who lead me to the trail. They deserve credit. Not sure if there is way to give them credit or not....
-- do work here BEGIN CODE BLOCK
Select #str = 'Insert into CustShip Values (' + '''' + #A_Cust_No + '''' + ', ' + '''' + #Ship_To_Id + '''' + ',3)'
EXEC(#str)
Select #str2 = 'Insert into ShipTo Values (' +
iif(#A_Cust_No is Null, 'Null', '''' + Replace(#A_Cust_No,'''','''''') + '''')
+ ', ' +
iif(#Ship_To_Name is Null, 'Null', '''' + Replace(#Ship_To_Name,'''','''''') + '''') + ', ' +
iif(#Ship_To_Add1 is Null, 'Null', '''' + Replace(#Ship_To_Add1,'''','''''') + '''') + ', ' +
iif(#Ship_To_Add2 is Null, 'Null', '''' + Replace(#Ship_To_Add2,'''','''''') + '''') + ', ' +
iif(#Ship_To_Add3 is Null, 'Null', '''' + Replace(#Ship_To_Add3,'''','''''') + '''') + ', ' +
iif(#City is Null, 'Null', '''' + Replace(#City,'''','''''') + '''') + ', ' +
iif(#Stat is Null, 'Null', '''' + Replace(#Stat,'''','''''') + '''') + ', ' +
iif(#Zip_Code is Null, 'Null', '''' + Replace(#Zip_Code,'''','''''') + '''') + ', ' +
iif(#Ship_To_Id is Null, 'Null', '''' + Replace(#Ship_To_Id,'''','''''') + '''') + ', ' +
iif(#Country is Null, 'Null', '''' + Replace(#Country,'''','''''') + '''') + ', 3)'
EXEC(#str2)
FETCH NEXT FROM C INTO #A_Cust_No, #Ship_To_Name, #SHIP_TO_ADD1, #SHIP_TO_ADD2, #SHIP_TO_ADD3, #CITY, #STAT, #ZIP_Code, #SHIP_TO_ID, #Country;
End
The following code is supposed to take a string that may or may not be comma delimited and put it into a table (#tmpFullanme) that part works flawlessly. The second part is supposed return all the values that are LIKE / NOT LIKE with or without % symbols based on what is input. The error that I am getting is "the multi-part identifier "#tmpFullname.Item" could not be bound." The best guess I have is that it may be out of scope?
DROP PROCEDURE uspJudgments;
GO
CREATE PROCEDURE uspJudgments
#fullName varchar(100), #SrchCriteria1 varchar(15), #SrchCriteria2 varchar(15), #qualifier varchar(10)
AS
BEGIN
SELECT *
INTO #tmpFullname
FROM dbo.DelimitedSplit8K(#fullName, ',')
DECLARE #Query NVarChar(1024)
SET #Query = 'SELECT d.*' + ' FROM defendants_ALL d, #tmpFullname' +
' WHERE d.combined_name' + ' ' + #qualifier + ' ' + '''' + #SrchCriteria1 + '''' + ' + ' + '''' + #tmpFullname.Item + '''' + ' + ' + '''' + #SrchCriteria2 + ''''
END
EXEC sp_executesql #Query
PRINT(#Query)
IF OBJECT_ID('#tmpFullname', 'U') IS NOT NULL
DROP TABLE #tmpFullname
EXEC uspJudgments #qualifier = 'LIKE', #fullName = 'johnson', #SrchCriteria1 = '%', #SrchCriteria2 = '%'
Cannot get to the PRINT output as "the multi-part identifier "#tmpFullname.Item" could not be bound." If I change #tmpFullname.Item to '#tmpFullname.Item it goes through and returns nothing but it shows that the query is correct minus the issue with that table.
SELECT d.* FROM defendants_ALL d, #tmpFullname WHERE d.combined_name LIKE '%' + '#tmpFullname.Item' + '%'
Please note that until I made this into a dynamic query so I can change the statement from LIKE to IN etc it worked very well.
I set up a full test to get the proper script to get you your desired results. I also have a SQL Fiddle showing how this works. Note You will want to run EXECUTE sp_executesql #Query inside the stored procedure
ALTER PROCEDURE uspJudgments #fullName varchar(100)
, #SrchCriteria1 varchar(15)
, #SrchCriteria2 varchar(15)
, #qualifier varchar(10)
AS
BEGIN
--Simulates your split function
SELECT *
INTO #tmpFullName
FROM
(
SELECT 'firstTest' AS Item
UNION ALL SELECT 'secondTest'
UNION ALL SELECT 'NotThere'
) AS t;
DECLARE #Query NVARCHAR(1024);
SELECT #Query = 'SELECT d.* '
+ ' FROM defendants_ALL d '
+ ' CROSS JOIN #tmpFullName AS t '
+ ' WHERE d.combined_name' + ' ' + #qualifier + ' '
+ '''' + #SrchCriteria1 + ''''
+ ' + ' + 't.Item' + ' + ' + '''' + #SrchCriteria2 + '''';
EXECUTE sp_executesql #Query;
END
EXECUTE uspJudgments
#fullName = 'does not matter'
, #SrchCriteria1 = '%'
, #SrchCriteria2 = '%'
, #qualifier = 'LIKE';
You have to use the tempdb prefix in this case
insert into tempdb..#TABLENAME
and
set #query = 'select * from tempdb..#TABLENAME'
Well, After my last answer i have found several things..
When i look into your procedure you start with the "BEGIN", next you do a insert into the "#tmpFullName" table, your declare the "#Query" variable and create a select statement.
After that you do and "END" with logic after it. You do the "sp_executesql" after that you drop the temptable and you do and EXEC of the current procedure..
The Structure isn't all that readable, sorry to tell you. So maybe you go there first.
Beside a strange structure you are using the "#tmpFullName.Item" in some dynamic SQL as a parameter, while it is declared inside the SQL query it self. So you have to do something like this :
SET #Query = 'SELECT d.*' + ' FROM defendants_ALL d, #tmpFullname' +
' WHERE d.combined_name' + ' ' + #qualifier + ' ' + '''' + #SrchCriteria1 + '''' + ' + ' + ' #tmpFullname.Item ' + ' + ' + '''' + #SrchCriteria2 + ''''
Where the "#tmpFullName.Item" resides insde the code, not as a parameter. But then again, what are you trying to achieve here? To answer this completly we have to know what the other variables are. Your structure isn't telling me what are trying to achieve..
I really can't make any more out of it...
What I am trying to do is export a Tsql query to a csv file. Simple enough, however I need to be able to specify which fields are wrapped in quotes "". I can get my query to export with all the feilds wrapped.
"SCHEN001","Joe Bloggs Inc","1","1","1","1","1","1","13","6","Mr John Smith"
What I would like to export is
"SCHEN001","Joe Bloggs Inc",1,1,1,1,1,1,13,6,"Mr John Smith"
Is this possible using Tsql?
Any ideas would be greatly appreciated
Take a look at the bcp.exe utility. It is ment for bulk operations and you can specify templates for exports etc.
A link that seems reasonable: http://www.simple-talk.com/sql/database-administration/creating-csv-files-using-bcp-and-stored-procedures/
Another approach is to use SQL Server Integration Services (if you have MS SQL Server Standard or Enterprise edition)
or, alternatively, you can copy grid results into Excel, and export CSV from there :-)
Try to use this script.
Set variable #TblName to the name of your table.
The script uses information_schema.columns
to get the datatypes for every column in selected table.
DECLARE #TblName varchar(128)
DECLARE #WhereClause varchar(255)
DECLARE #cmd varchar(7000)
SET #TblName = '<YOUR TABLENAME>' --TABLENAME
SET #cmd = ''
create table #tableDef (id int identity (1,1), ColType int, ColName varchar(128))
--Fetch table information
insert #tableDef (ColType, ColName)
select case when DATA_TYPE like '%char%' then 1
when DATA_TYPE like '%datetime%' then 2
else 0 end ,
COLUMN_NAME
from information_schema.columns
where TABLE_NAME = #TblName
order by ORDINAL_POSITION
SELECT #cmd = #cmd
+ ' CASE WHEN ' + ColName + ' IS NULL '
+ ' THEN ''NULL'' '
+ ' ELSE '
+ case ColType
when 1 then ''''''''' + ' + ColName + ' + '''''''''
when 2 then ''''''''' + ' + 'CONVERT(VARCHAR(20),' + ColName + ')' + ' + '''''''''
else 'CONVERT(VARCHAR(20),' + ColName + ')' end
+ ' END + '','' + '
from #tableDef
order by id
select #cmd = 'SELECT ' + left(#cmd,len(#cmd)-8) + '+'''' FROM ' + #tblName
exec (#cmd)
drop table #tableDef
I have the following dynamic sql statement where I want to add #StartRowIndex + #MaximumRows and subtract 1 from it. I am unclear on where to put the single quotes in the statement. Here it is:
SET #sql = #sql + ' SELECT *
FROM
LicenseInfo
WHERE RowNum
BETWEEN ' + #StartRowIndex + ' AND ' +
'(' + #StartRowIndex + #MaximumRows + ')' - 1
+ ' ORDER BY cnt desc'
Create new variable #EndRowIndex and calculate it before you construct the dynamic sql statement.
Something like:
DECLARE #EndRowIndex int
SET #EndRowIndex = #StartRowIndex + #MaximumRows - 1
SET #sql = #sql + ' SELECT *
FROM
LicenseInfo
WHERE RowNum
BETWEEN ' + #StartRowIndex + ' AND ' + #EndRowIndex
+ ' ORDER BY cnt desc'
You need to cast the int parameters into varchar
SET #sql = #sql + ' SELECT *
FROM
LicenseInfo
WHERE RowNum
BETWEEN ' + #StartRowIndex + ' AND ' +
'(' + CAST(#StartRowIndex as varchar(10)) + CAST(#MaximumRows as varchar(10)) + ') - 1
ORDER BY cnt desc'
Declare a variable, do the calculation and CAST it to varchar when generating the SQL statement
DECLARE #LastRowIndex int
SET #LastRowIndex = #StartRowIndex + #MaximumRows - 1
SET #sql = #sql + '
SELECT *
FROM LicenseInfo
WHERE 1=1
AND RowNum BETWEEN ' + CAST (#StartRowIndex as VarChar) +
' AND ' + CAST (#LastRowIndex as VarChar)
+ ' ORDER BY cnt DESC'
You have to cast in order to let SQL Server concatenate string values, otherwise it will try to convert the nVarChar to number and try to add them as numerics.