Add new values to PSObject - Is this the best approach? - powershell

Question

I have the following code and it works. But I was wondering if this was the best approach as it repeats the structure over and over again.
$Computers = Get-Content -Path C:\scripts\Computers.txt
$AllComputers = #()
foreach ($machine in $Computers) {
$objCompSys = Get-WmIObject -class "Win32_ComputerSystem" -cn $machine -EA silentlyContinue -namespace "root\CIMV2"
foreach ($item in $objCompSys) {
$compname = $item.Name
$physicalRAM = [Math]::Ceiling($item.TotalPhysicalMemory / 1MB)
$numProcs = $item.NumberOfProcessors
}
$objProc = Get-WMIObject -class "Win32_Processor" -cn $machine -EA silentlyContinue -namespace "root\CIMV2"
foreach ($item in $objProc) {
$procType = $item.Name
$procSpeed = $item.MaxClockSpeed
}
if (procSpeed -eq "486") {
$Data1 = #{
MachineName = $compname
CPUSpeed = $procSpeed
"Num CPUs" = $numProcs
"Physical RAM" = $physicalRAM
"Summary" = "486 process - check"
New-Object PSObject -Property $data1
}
$AllComputers += $Data1
} elseif (procSpeed -eq "586") {
$Data2 = #{
MachineName = $compname
CPUSpeed = $procSpeed
"Num CPUs" = $numProcs
"Physical RAM" = $physicalRAM
"Summary" = "586 process - check"
New-Object PSObject -Property $data2
}
$AllComputers += $Data2
} else (procSpeed -eq "6*") {
$Data3 = #{
MachineName = $compname
CPUSpeed = $procSpeed
"Num CPUs" = $numProcs
"Physical RAM" = $physicalRAM
"Summary" = "New Models - Good to go"
New-Object PSObject -Property $data3
}
$AllComputers += $Data3
}
}
$AllComputers | Out-GridView

Answer 1

Yes. Set up your "Data" table once, and then change just the "Summary" field if necessary:
$Computers = Get-Content -Path C:\scripts\Computers.txt
$AllComputers = #()
foreach($machine in $Computers)
{
$objCompSys = Get-WmIObject -class "Win32_ComputerSystem" -cn $machine -EA silentlyContinue -namespace "root\CIMV2"
foreach($item in $objCompSys)
{
$compname = $item.Name
$physicalRAM = [Math]::Ceiling($item.TotalPhysicalMemory / 1MB)
$numProcs = $item.NumberOfProcessors
}
$objProc = Get-WMIObject -class "Win32_Processor" -cn $machine -EA silentlyContinue -namespace "root\CIMV2"
foreach($item in $objProc)
{
$procType = $item.Name
$procSpeed = $item.MaxClockSpeed
}
$Data = #{
MachineName = $compname
CPUSpeed = $procSpeed
"Num CPUs" = $numProcs
"Physical RAM" = $physicalRAM
}
$Data["Summary"] = switch($procSpeed)
{
"486" { "486 process - check" }
"586" { "586 process - check" }
default { "New Models - Good to go" }
}
$AllComputers += New-Object psobject -Property $Data
}
$AllComputers | Out-GridView
The switch above is comparable to this if/else construct:
if($procSpeed -eq "486") {
"486 process - check"
} elseif($procSpeed -eq "486") {
"586 process - check"
} else {
"New Models - Good to go"
}