Perl Script not running correctly - perl

When ever I run this bit of code. it doesn't display any output. Anyone see anything wrong?
I am trying to display this in the out put:
A
AA
AAA
AAAB
AAABA
AAABAA
AAABAAA
AAABAAAB
etc.
#!/usr/local/bin/perl
$A = 3;
$B = 1;
$i = 1;
$output = "";
$j = 1;
while ($i <= $ARGV[0]) {
while ($j <= $i) {
if ($A == 0 && $B == 0) {
$A = 3;
$B = 1;
}
if ($A > 0) {
$output.= "A";
$A--;
}
else {
$output.= "B";
$B--;
}
$j++;
}
print($output . "\n");
$i++;
}

It works for me when I run it with a numeric argument (number of lines).
An idea how to simplify the code:
#!/usr/bin/perl
use warnings;
use strict;
my $count = shift;
my $A = 3;
my $B = 1;
my $string = q();
$string .= ('A' x $A) . ('B' x $B) while $count > length $string;
print substr($string, 0, $_), "\n" for 1 .. $count;
It uses a different algorithm - it creates the longest possible string, and then outputs parts of it.

if there is no #ARGV, while ($i <= $ARGV[0]) never runs.
#ARGV is an array of the command line arguments provided when the script is executed. you did not provide any command line arguments. if you had use warnings in effect, you would be warned that $ARGV[0] is uninitialized.

As from ikegami comment. You cann't pass the input at when the program is compile. For example, consider your file name is algo.pl. Can you run your program with
perl algo.pl 10
Here 10 is the input value of the program. In program value is retrieve by the $ARGV[0]
so in your program looks like while ($i <= $ARGV[0]).
If you want pass the several values like perl filename.pl 12 data1 data2In your data retrieve by $ARGV[0] $ARGV[1] $ARGV[2] for more information see here.
If you want pass the input at the time of execution used STDIN
use warnings;
use strict;
my $A = 3;
my $B = 1;
my $i = 1;
my $output = "";
my $j = 1;
print "Enter the value: ";
chomp(my $value = <STDIN>);
while ($i <= $value) {
while ($j <= $i) {
if ($A == 0 && $B == 0) {
$A = 3;
$B = 1;
}
if ($A > 0) {
$output.= "A";
$A--;
}
else {
$output.= "B";
$B--;
}
$j++;
}
print($output . "\n");
$i++;
}

Related

Unable to modify array parameter

This is supposed to put the contents of nums into decreasing order, however sort does not change the contents of nums. Many sites I read have said to pass by reference, but I don't think I'm dereferencing the argument correctly. Bear with me, this is my first Perl program :)
#! /usr/bin/env perl
sub sort {
my #arr = #_;
my $len = scalar #arr;
for (my $i = 1; $i < $len-1; $i = $i + 1) {
my $max = $i;
for (my $j = $i + 1; $j < $len; $j = $j + 1) {
if ($arr[$j] > $arr[$max]) {
$max = $j
}
}
$temp = $arr[$max];
$arr[$max] = $arr[$i];
$arr[$i] = $temp;
}
}
print "Enter 10 numbers: ";
my $numbers = <STDIN>;
my #nums = split ' ', $numbers;
print "Unsorted: #nums\n";
sort \#nums;
print "Sorted: #nums\n";
#Matt Jacob helped me out with this one. This is what I was looking for.
#! /usr/bin/env perl
sub selection_sort {
my $arr = shift;
my $len = scalar #$arr;
for (my $i = 0; $i < $len-1; $i++) {
my $max = $i;
for (my $j = $i + 1; $j < $len; $j++) {
if (#$arr[$j] > #$arr[$max]) {
$max = $j
}
}
my $temp = #$arr[$max];
#$arr[$max] = #$arr[$i];
#$arr[$i] = $temp;
}
}
print "Enter 10 numbers: ";
my $input = <STDIN>;
my #integers = split ' ', $input;
print "Unsorted: #integers\n";
selection_sort \#integers;
print "Sorted: #integers\n";

how to output into a tree like structure via Tree::DAG_Node?

I'm trying to write a program that can read from a file then put into a heap sort then output in a tree along with the sorted list. But I got stuck, instead of having the put be the numbers used in the heap sort, it just post 1-10 on one line then 1-9 on the next line. I'm really confused and I barely understand this language as it is. I put a example of the out below alone with the output I am hoping to have it draw.
#!/usr/bin/perl
use 5.006;
use strict;
use warnings;
use Tree::DAG_Node;
process_data(read_file('testing.txt'));
process_data((3,1,4,1,5,9,2,6,5,3,6));
sub read_file{
my($filename)=#_;
my #data=();
my #words;
open(my $fh, "<", $filename)
or die "Could not open file: $!\n";
while(<$fh>){
chomp;
#words = split(' ');
foreach my $word(#words){
push #data, $word;
}
}
close $fh;
return #data;
}
sub heap_sort {
my ($a) = #_;
my $n = #$a;
for (my $i = ($n - 2) / 2; $i >= 0; $i--) {
down_heap($a, $n, $i);
}
for (my $i = 0; $i < $n; $i++) {
my $t = $a->[$n - $i - 1];
$a->[$n - $i - 1] = $a->[0];
$a->[0] = $t;
down_heap($a, $n - $i - 1, 0);
}
}
sub down_heap {
my ($a, $n, $i) = #_;
while (1) {
my $j = max($a, $n, $i, 2 * $i + 1, 2 * $i + 2);
last if $j == $i;
my $t = $a->[$i];
$a->[$i] = $a->[$j];
$a->[$j] = $t;
$i = $j;
}
sub max {
my ($a, $n, $i, $j, $k) = #_;
my $m = $i;
$m = $j if $j < $n && $a->[$j] > $a->[$m];
$m = $k if $k < $n && $a->[$k] > $a->[$m];
return $m;
}
}
sub draw_tree{
my(#data)=#_;
my $root = Tree::DAG_Node->new;
$root->name($_[0]);
$root->new_daughter->name($_) for (1..10);
my #names = #data;
my $count = 50;
for my $n ($root->daughters) {
for (split //, $names[$count++]) {
$n->new_daughter->name($_)
}
}
print map "$_\n", #{$root->draw_ascii_tree};
}
sub process_data{
my(#data)=#_;
my #a = #data;
print "#a\n";
print "\n";
heap_sort(\#a);
draw_tree(#a);
print "\n";
print "#a\n";
print "\n";
}
here is the output I get
CMD output of my code
Output I am expecting:
(using example data)
1 1 9 4 5
1
|
1 ----- 9
|
/\
4 5
1 1 4 5 9

How to make this Perl program print in descending order?

This code works but it prints in ascending order. Do I need to change my whole formula?
print "Enter an integer \n";
my $root = <STDIN>;
my #nums = (100..200);
my $i = 0;
# code in while loop executes as long as condition is true
while ( $i < $#nums )
{
print "$nums[$i]\n",if($nums[$i] % $root == 0); $i++;
}
Just set $i to $#nums instead of 0 and decrement it -- instead of incrementing. You'll need to change the loop condition to $i >= 0 (it should be $i <= $#nums in your code, otherwise it skips 200 when 10 was entered).
#!/usr/bin/perl
use warnings;
use strict;
print "Enter an integer \n";
my $root = <>;
my #nums = (100 .. 200);
my $i = $#nums;
while ( $i >= 0 ) {
print "$nums[$i]\n" if $nums[$i] % $root == 0;
--$i;
}
There are more than a few ways to do it ... not all equally good:
#!/usr/bin/env perl
use strict;
use warnings;
run(#ARGV);
sub run {
my $root = $_[0] // get_root();
my #nums = (100 .. 200);
my #functions = (
sub {
my ($root, $nums) = #_;
my $i = #$nums;
while ($i--) {
print "$nums->[$i]\n" unless $nums->[$i] % $root;
}
return;
},
sub {
my ($root, $nums) = #_;
for my $n ( reverse #$nums ) {
print "$n\n" unless $n % $root;
}
return;
},
sub {
my ($root, $nums) = #_;
my $i;
while ($i++ < #$nums) {
print "$nums->[#$nums - $i]\n" unless $nums->[#$nums - $i] % $root;
}
return;
},
sub {
my ($root, $nums) = #_;
my #multiples = reverse grep !($_ % $root), #$nums;
print "$_\n" for #multiples;
return;
},
);
for my $i ( 0 ... $#functions ) {
print "=== Function $i ===\n";
$functions[$i]->($root, \#nums);
}
}
sub get_root {
return scalar <STDIN>;
}
print "Enter an integer \n";
my $root = <STDIN>;
my #nums = (100..200);
#nums = reverse #nums; #Just reverse the arrays
my $i = 0;
# code in while loop executes as long as condition is true
while ( $i < $#nums )
{
print "$nums[$i]\n",if($nums[$i] % $root == 0); $i++;
}
May be it will helps you.
for (my $i = $#nums; $i >= 0; --$i) { ... }
for (my $i = #nums; $i--; ) { ... }
for my $i (reverse 0 .. $#nums) { ... }
for (1 .. #nums) { my $i = -$_; ... } # Or: my $i = #nums-$_;
for my $num (reverse #nums) { ... }

Global symbol requires explicit package name issue

I'm attempting to write a program that will determine if a 7-character string is a palindrome or not, and it keeps throwing me this error. I'm not exactly sure why it's doing it or how to fix it.
#!/usr/bin/perl
use Modern::Perl;
use strict;
use warnings;
print "Enter a 7 character string: ";
chomp (my $pal = <>);
my $size = length($pal);
if ($size == 7) {
$pal[0] = my $a; # Here's where it starts throwing errors
$pal[1] = my $b;
$pal[2] = my $c;
$pal[3] = my $d;
$pal[4] = my $e;
$pal[5] = my $f;
$pal[6] = my $g; # All the way to down here
if ($a eq $g) && ($b eq $f) && ($c eq $e) {
print "PALINDROME\n";
}
else {
print "NOT A PALINDROME\n";
}
}
else {
print "Your string must contain 7 characters!\n";
}
I am not allowed to use the reverse function in this code. Also, I'm pretty new to Perl, so please keep things basic for me.
You're using $pal as an array, but it's not. This collects from STDIN into $input, then transforms that into a #pal array which you're operating on. Your = variables were backwards, it's recommended not to use $a or $b as they are special in Perl, and you were missing parens around your if statement. This should get you going:
use strict;
use warnings;
print "Enter a 7 character string: ";
my $input = <STDIN>;
chomp $input;
my $size = length($input);
my #pal = split //, $input;
if ($size == 7) {
my $a = $pal[0];
my $b = $pal[1];
my $c = $pal[2];
my $d = $pal[3];
my $e = $pal[4];
my $f = $pal[5];
my $g = $pal[6];
if (($a eq $g) && ($b eq $f) && ($c eq $e)){
print "PALINDROME\n";
}
else {
print "NOT A PALINDROME\n";
}
}
else {
print "Your string must contain 7 characters!\n";
}
Here's an example if statement using #Biffen suggestion as your comparison instead of assigning the whole array into single scalars.
if ($size == 7) {
if ($pal[0] eq $pal[6] && $pal[1] eq $pal[5] && $pal[2] eq $pal[4]){
print "PALINDROME\n";
}
else {
print "NOT A PALINDROME\n";
}
}
You can't use the string $pal as an array in perl (one of the many ways that perl is not C). It'll tell you that #pal doesn't exist. You need to use substr, and your assignments are also backwards:
my $c0 = substr($pal, 0, 1);
my $c1 = substr($pal, 1, 1);
my $c2 = substr($pal, 2, 1);
my $c3 = substr($pal, 3, 1);
my $c4 = substr($pal, 4, 1);
my $c5 = substr($pal, 5, 1);
my $c6 = substr($pal, 6, 1);
if ($c0 eq $c6) && ($c1 eq $c5) && ($c2 eq $c4) {
print "PALINDROME\n";
}
else {
print "NOT A PALINDROME\n";
}
Using $a and $b can cause problems, so I've renamed the variables.
Simplifying slightly:
#!/usr/bin/perl
use strict;
use warnings;
use 5.010;
print 'Enter a 7 character string: ';
chomp(my $string = <STDIN>);
my #pal = split //, $string;
die "$string is not a 7 character string\n"
if #pal != 7;
for (0 .. 2) {
if ($pal[$_] ne $pal[$#pal - $_]) {
say "$string is not a palindrome";
exit;
}
}
say "$string is a palindrome";

Best way to alternate a variable value in loop? (Perl)

my #arr = (1,2,3,4,5,6,7,8,9);
my $counter = 0;
foreach my $a (#arr) {
my $str;
if ($counter % 2 == 0) {
$str = 'hi';
} else {
$str = 'bye';
}
print $str . "\n";
$counter++;
}
What is the best way to alternate between two different values for each iteration of a while loop? Simple example above, is there a better way than keeping a counter and modding to find even values?
my #arr = qw( a b c );
for my $i (0..$#arr) {
print "$arr[$i] ", $i % 2 ? 'bye' : 'hi', "\n";
}
Good name.
my /*boolean*/ $even = 0;
foreach ...
next if ... # skipping line
$even = !$even;
... # work
print $even ? 'hi' : 'bye';
I'd do like this:
...
my #arr = (1..9);
for (my $i=0; $i<scalar(#arr); $i++) {
my $str = ($i % 2 == 0) ? 'hi' : 'bye';
print "$str\n";
}
my ($foo, $bar) = qw(foo bar);
for (0..10) {
print "$foo\n";
($foo, $bar) = ($bar, $foo);
}
A weird one, but no counters and no modding to find even values:
use strict;
sub foo {
shift || return and bar(#_);
print "doing something with Value2 \n";
}
sub bar {
shift || return and foo(#_);
print "doing something with Value1 \n";
}
foo(1..100);
Do whatever you want by calling foo() or bar() and chosing an even or odd values insted of 100. Maybe you would like to use $#arr insted of hardcoded values and so on.
But please don't write code like this.
Couldn't resist:
my #arr = (1,2,3,4,5,6,7,8,9);
my #alt = qw( hi bye );
my $counter = 0;
foreach my $a (#arr) {
print $alt[($counter++ % 2)] . "\n";
}
Or per dolmen's comment using "&" which should be more efficient compared to modulo (%)
my #arr = (1,2,3,4,5,6,7,8,9);
my #alt = qw( hi bye );
my $counter = 0;
foreach my $a (#arr) {
print $alt[($counter++ & 1)] . "\n";
}