How to replace myproduct.exe with renamed eclipsec.exe - eclipse

Question

I have an Eclipse RCP product.
I am (ab?)using the p2.inf file, located in the directory the .product file is located in, to remove the .exe file and rename the eclipsec.exe file to the .exe file. The content looks as follows:
instructions.configure = \
org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/eclipsec.exe, target:${installFolder}/myproductname.exe, overwrite:true);\
org.eclipse.equinox.p2.touchpoint.natives.remove(path:${installFolder}/eclipsec.exe);
I need to build this product for windows and linux with maven tycho. For windows the p2.inf file instructions work fine. For linux this fails, which I am not surprised about (there is no .exe file).
Is there a way to execute those instructions for windows only / ignore the p2.inf file for linux builds when the product is built with tycho (for linux just 1 executable is generated anyway)?
Thanks in advance.
Tycho version: 1.0.0
Eclipse SDK version: 4.7.0

Answer 1

This can be done either:
with a fragment that contains the p2.inf file and that has the Platform Filter: (osgi.os=linux) or
by defining an installation unit (IU) similar to the example described here that contains a line like units.0.filter=(osgi.os=linux). (see also Customizing Metadata in Eclipse help and in the Eclipse wiki)
If possible, the first option is preferable, since the second option is more complex and requires more knowledge about p2.
Note, your root problem seems to be Eclipse bug 185205. Maybe you'd like to vote for it or comment on it. I suspect there is a better workaround than do a copy via p2 for that.

Answer 2

I have to solve it myself, posting complete solution here using windows filter.
Create file p2.inf in the "Product" project of your application
(or feature project).
Change MYPRODUCT to your own branding name.
When copying make sure there are no trailing spaces after backslashes in touchpoint actions or it won't work.
#create a requirement on the fragment we are creating
requires.22.namespace=org.eclipse.equinox.p2.iu
requires.22.name=MYPRODUCT.eclipsecoverride.config.win32.win32.x86_64
requires.22.range=[$version$,$version$]
requires.22.greedy=true
requires.22.filter=(osgi.os=win32)
#create a IU fragment with touchpoint action
units.0.id = MYPRODUCT.eclipsecoverride.config.win32.win32.x86_64
units.0.version = $version$
units.0.provides.1.namespace=org.eclipse.equinox.p2.iu
units.0.provides.1.name=MYPRODUCT.eclipsecoverride.config.win32.win32.x86_64
units.0.provides.1.version=$version$
units.0.filter=(osgi.os=win32)
units.0.instructions.configure = \
org.eclipse.equinox.p2.touchpoint.natives.copy(\
source:${installFolder}/eclipsec.exe,\
target:${installFolder}/MYPRODUCT_console.exe,overwrite:true);\
org.eclipse.equinox.p2.touchpoint.natives.remove(\
path:${installFolder}/eclipsec.exe);

Answer 3

How I moved eclipsec.exe to myproduct.exe (overwritten) without destroying the linux build
I added a myproduct.p2.inf file next to my myproduct.product file with the following content:
instructions.configure = \
org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/eclipsec.exe, target:${installFolder}/myproduct.exe, overwrite:true);\
org.eclipse.equinox.p2.touchpoint.natives.remove(path:${installFolder}/eclipsec.exe);\
org.eclipse.equinox.p2.touchpoint.natives.remove(path:${installFolder}/../../../../linux/gtk/x86_64/myproduct/myproduct.exe);
With this state the copy instruction will fail for Linux builds because there is no eclipsec.exe file (FileNotFoundException). It's generated for Windows builds only.
Note that the copy instruction fails if specified files are not found while the remove instruction simply isn't executed in case the specified file does not exist.
Workaround
To work around this problem I added the empty file org.example.feature/filesToCopy/eclipsec.exe to my feature (which is included in my feature based product) and added the line root.linux.gtk.x86_64=filesToCopy to the build.properties of the feature project. This copies the empty eclipsec.exe file to the Linux build.
What happens for Windows:
The product is built with eclipsec.exe and myproduct.exe
eclipsec.exe is copied to myproduct.exe (which overrides myproduct.exe)
eclipsec.exe is deleted
--> myproduct.exe is the only executable (next to the myproduct.ini file). All brandings are lost though!
What happens for Linux:
The product is built with the myproduct executable and an empty eclipsec.exe file.
eclipsec.exe is copied to myproduct.exe
eclipsec.exe is deleted
myproduct.exe is deleted too
--> The linux archive looks exactly as it was built by tycho. All the copying and renaming of *.exe files have no other purpose than making it possible to execute the copy instruction in the p2.inf file which is required for the Windows build.