append data retrieved from API for loop to array - swift

Question

I'm having issues using a for loop to append data retrieved from an API to an array. I am attempting to use the array to dequeue cells in a tableview. I edited the question to comply with the answer provided but received errors at numberofrowsinsection (placed integer to check for more errors) and cellforrowat.
This is code in the view controller:
class BusinessesViewController: UIViewController, UITableViewDataSource, UITableViewDelegate {
var businesses: [Business] = []
#IBOutlet weak var tableView: UITableView!
override func viewDidLoad() {
super.viewDidLoad()
Business.searchWithTerm(term: "Restaurants", sort: .distance, categories: nil) { (businesses, error) in
self.businesses = businesses!
}
self.tableView.reloadData()
}
override func didReceiveMemoryWarning() {
super.didReceiveMemoryWarning()
// Dispose of any resources that can be recreated.
}
func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
return businesses.count
}
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "Business") as! SelectTableViewCell
let business = businesses[indexPath.row]
cell.BusinessName.text = business.name
return cell
}
}
this is current console printout returned
["sort_by": distance, "open_now": 0, "term": Restaurants, "location": 37.785771,-122.406165]
Optional([<Decided.Business: 0x600000123520>, <Decided.Business: 0x600000123700>, <Decided.Business: 0x600000123c00>, <Decided.Business: 0x600000123ca0>, <Decided.Business: 0x600000123b60>, <Decided.Business: 0x604000124060>, <Decided.Business: 0x6040001241a0>, <Decided.Business: 0x604000124240>, <Decided.Business: 0x6040001244c0>, <Decided.Business: 0x604000124560>, <Decided.Business: 0x604000124600>, <Decided.Business: 0x600000123f20>, <Decided.Business: 0x6040001246a0>, <Decided.Business: 0x604000124740>, <Decided.Business: 0x6040001247e0>, <Decided.Business: 0x604000124880>, <Decided.Business: 0x600000124240>, <Decided.Business: 0x6000001242e0>, <Decided.Business: 0x600000124380>, <Decided.Business: 0x6000001244c0>])
This is the model I am using:
import UIKit
class Business: NSObject {
let name: String?
let address: String?
let imageURL: URL?
let categories: String?
let distance: String?
let ratingImage: UIImage?
let reviewCount: NSNumber?
init(dictionary: NSDictionary) {
name = dictionary["name"] as? String
let imageURLString = dictionary["image_url"] as? String
if imageURLString != nil {
imageURL = URL(string: imageURLString!)
} else {
imageURL = nil
}
let location = dictionary["location"] as? NSDictionary
var address = ""
if location != nil {
let addressArray = location!["display_address"] as? NSArray
if addressArray != nil {
if addressArray!.count > 0 {
address = addressArray![0] as! String
}
if addressArray!.count > 1 {
address += ", " + (addressArray![1] as! String)
}
}
}
self.address = address
let categoriesArray = dictionary["categories"] as? [NSDictionary]
if categoriesArray != nil {
var categoryNames = [String]()
for category in categoriesArray! {
let categoryName = category["title"] as! String
categoryNames.append(categoryName)
}
categories = categoryNames.joined(separator: ", ")
} else {
categories = nil
}
let distanceMeters = dictionary["distance"] as? NSNumber
if distanceMeters != nil {
let milesPerMeter = 0.000621371
distance = String(format: "%.2f mi", milesPerMeter * distanceMeters!.doubleValue)
} else {
distance = nil
}
let rating = dictionary["rating"] as? Double
if rating != nil {
switch rating {
case 1:
self.ratingImage = UIImage(named: "stars_1")
break
case 1.5:
self.ratingImage = UIImage(named: "stars_1half")
break
case 2:
self.ratingImage = UIImage(named: "stars_2")
break
case 2.5:
self.ratingImage = UIImage(named: "stars_2half")
break
case 3:
self.ratingImage = UIImage(named: "stars_3")
break
case 3.5:
self.ratingImage = UIImage(named: "stars_3half")
break
case 4:
self.ratingImage = UIImage(named: "stars_4")
break
case 4.5:
self.ratingImage = UIImage(named: "stars_4half")
break
case 5:
self.ratingImage = UIImage(named: "stars_5")
break
default:
self.ratingImage = UIImage(named: "stars_0")
break
}
} else {
self.ratingImage = UIImage(named: "stars_0")
}
reviewCount = dictionary["review_count"] as? NSNumber
}
class func businesses(array: [NSDictionary]) -> [Business] {
var businesses = [Business]()
for dictionary in array {
let business = Business(dictionary: dictionary)
businesses.append(business)
}
return businesses
}
class func searchWithTerm(term: String, completion: #escaping ([Business]?, Error?) -> Void) {
_ = YelpClient.sharedInstance.searchWithTerm(term, completion: completion)
}
class func searchWithTerm(term: String, sort: YelpSortMode?, categories: [String]?, completion: #escaping ([Business]?, Error?) -> Void) -> Void {
_ = YelpClient.sharedInstance.searchWithTerm(term, sort: sort, categories: categories, openNow: false, completion: completion)
}
}

Answer 1

Your main mistake is that you are declaring Names as a String.
After appending Hot Dog Stand the table view is creating 13 cells because the string has 13 characters which is returned in numberOfRows.
You probably want
Business.searchWithTerm(term: "Restaurants", sort: .distance, categories: nil) { (businesses, error) in
if let error = error { print(error); return }
self.businesses = businesses!
DispatchQueue.main.async {
self.tableView.reloadData()
}
}
func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
return businesses.count
}
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "Business") as! SelectTableViewCell
let business = businesses[indexPath.row]
cell.BusinessName.text = business.name
return cell
}
and delete the Names property