I have a PR that has been submitted that I have requested small updates/ changes to be made to. The user has switched GitHub profiles during the time the PR was open to the time I reviewed the PR. He now wants to be able to submit the changes to the PR as his new username. Is there a way to give the new user write access to the PR?
Here is a link to the PR for reference.
Related
We are working with Azure Devops, merge into main only via PR.
If the QA team reject the PR because of some bug in the code, and the developer fixed the bug - do we have to open a new PR?
Can we not update the code on the current PR and re-submit it?
Thank you.
Rejecting a PR is a vote on PR changes
It odes not prevent you to push additional commits on it, requesting for a feedback reset, and a new vote.
You can use a branch policy:
To reset votes whenever a PR author pushes new changes, select Reset code reviewer votes when there are new changes in the Require a minimum number of reviewers branch policy.
As far as I could find Azure DevOps only allows to review Pull Requests by Update on the PR. I can't find any way to review the commits in the PR such that I could review the commits one by one and have comments showing up in the PR. If I simply leave a comment on a commit, it's a global comment in the repository. Does anyone know of a way to review the commits one by one?
You could see the commits for a PR in link https://dev.azure.com/{org}/Git/_git/Git/pullrequest/{id}?_a=commits, but the comments you add in the commit won't show on the Overview of a PR, you have to click into the commit and check the comments.
I'm not sure if this is an appropriate question for SO but say I make a PR in Github and the reviewers of the PR request changes before it is merged. When I subsequently commit the requested changes on my branch that I am trying to merge are the reviewers notified that I have made the change? Or do I need to explicitly comment on the PR that I have made the change and tag the reviews?
When I subsequently commit the requested changes on my branch that I am trying to merge are the reviewers notified that I have made the change?
They will be able to see/notified you made a new commit, but they won't know if it addresses the PR concerns (or if you're simply adding unrelated changes). Best practice is to comment on the PR and tell them you made changes - tagging the reviewer(s) definitely won't hurt!
Since February 2019, no need to comment: you can Re-request review on a pull request
If changes have been made to a pull request that has already been reviewed, you can now re-request a review with a single click in the pull request’s sidebar. This will notify the requested reviewers that changes have been made.
When I create a repo on GitHub, it's almost always because I have code to push that is ready for review. But by default, only the organization admin can see a new repo right after it's been created. This prevents me from adding other reviewers to the PR that I create immediately after that.
Is there a way to set this up so that everyone on my team will appear in the list of potential reviewers for every new repo as it's created?
Using the new pull request approval process in Github, if I approve a PR but then a dev pushes a new commit to that branch I'd want the PR to go back to the state it is in to start with (i.e. not approved).
At the moment it stays green but in reality there is code that hasn't been reviewed in the branch.
On GitHub, navigate to the main page of the repository.
Under your repository name, click Settings.
In the left menu, click Branches.
Select the branch you want to restrict using the drop-down menu.
Select Dismiss stale pull request approvals when new commits are pushed.
This dismisses a pull request approval review when a code-modifying commit is pushed to the branch.
Click Save changes.
Ref: https://help.github.com/articles/enabling-required-reviews-for-pull-requests/
It's not clear from your question if you need this automatically done, or if a manual process is okay too.
In my case a manual solution was fine. We'll just rely on developers to use their judgment on whether a PR should be unapproved.
To manually unapprove a PR, you can go to the comments section where the approval is, and click "show all reviewers". Then choose Dismiss for each approved review.