Mongoose: findByIdAndUpdate is not working even after passing {new:true} - mongodb

Question

POST and DELETE requests are working but PUT is not working even after passing {new: true} as other answers suggested.
I checked the documentation for mongoose and didn't find anything that might solve the problem.
Terminal log is: PUT /api/persons/5dfbb8677d7d960358dbdead 404 175 - 2.273 ms -
The request body is not logging and only a '-' is logged. This is not the case with POST.
Relevant code:
app.post('/api/persons', (request, response) => {
const body = request.body
const person = new Person({
name: body.name,
number: body.number,
})
person
.save()
.then(savedContact => {
response.json(savedContact.toJSON())
})
})
app.put('api/persons/:id', (request, response, next) => {
const body = request.body
const person = {
name: body.name,
number: body.number,
}
person
.findByIdAndUpdate(request.params.id, person, { new: true })
.then(updatedContact => {
response.json(updatedContact.toJSON())
})
.catch(error => next(error))
})
app.delete('/api/persons/:id', (request, response, next) => {
Person
.findByIdAndRemove(request.params.id)
.then(result => {
response.status(204).end()
})
.catch(error => {next(error)})
const errorHandler = (error, request, response, next) => {
if (error.name === 'CastError' && error.kind == 'ObjectId') {
return response.status(400).send({ error: 'malformatted id' })
}
next(error)
}
app.use(errorHandler)
})
Complete File:
require('dotenv').config()
const express = require('express')
const app = express()
app.use(express.static('build'))
const bodyParser = require('body-parser')
app.use(bodyParser.json())
const cors = require('cors')
app.use(cors())
const morgan = require('morgan')
morgan.token('req_body', function(req, res) {
if (req.method === 'POST' || req.method === 'PUT'){
return JSON.stringify(req.body);
}
});
morgan.token('req_key', function(req, res) {
if (req.method === 'GET' || req.method === 'PUT'){
return JSON.stringify(req.params.id);
}
});
app.use(morgan(':method :url :status :res[content-length] - :response-time ms :req_body :req_key'))
const Person = require('./models/person')
app.get('/api/persons', (request, response) => {
Person.find({}).then(persons => {
response.json(persons.map(person => person.toJSON()))
})
})
app.get('/api/persons/:id', (request, response) => {
Person
.findById(request.params.id)
.then(person => {
response.json(person.toJSON())
})
.catch(error => {
console.log(error)
response.status(404).end()
})
})
app.post('/api/persons', (request, response) => {
const body = request.body
const person = new Person({
name: body.name,
number: body.number,
})
person
.save()
.then(savedContact => {
response.json(savedContact.toJSON())
})
})
app.put('api/persons/:id', (request, response, next) => {
const body = request.body
const person = {
name: body.name,
number: body.number,
}
Person
.findByIdAndUpdate(request.params.id, person, { new: true })
.then(updatedContact => {
response.json(updatedContact.toJSON())
})
.catch(error => next(error))
})
app.delete('/api/persons/:id', (request, response, next) => {
Person
.findByIdAndRemove(request.params.id)
.then(result => {
response.status(204).end()
})
.catch(error => {next(error)})
})
const errorHandler = (error, request, response, next) => {
if (error.name === 'CastError' && error.kind == 'ObjectId') {
return response.status(400).send({ error: 'malformatted id' })
}
next(error)
}
app.use(errorHandler)
const PORT = process.env.PORT
app.listen(PORT, ()=>{console.log(`Server running on ${PORT}`)})

Answer 1

Your person object is wrong so not update record.
app.put('/api/persons/:id', (request, response, next) => {
const body = request.body
const person = {
name: body.name,
number: body.number,
}
Person
.findByIdAndUpdate(request.params.id, person, { new: true })
.then(updatedContact => {
response.json(updatedContact.toJSON())
})
.catch(error => next(error))
})