Spring Batch support for OpenEdge database? - spring-batch

Question

The company I work for has to support different databases and one of them is OpenEdge, which I never used before. We have a project using Spring Boot, Spring Data JPA and Spring Batch.
We added a few custom classes to make Spring Batch work with OpenEdge but we are having DB locking issues whereas it works fine for MS SQL Server and Oracle. Anybody using Spring Batch with OpenEdge DB? Does anybody know if Spring Batch will ever support OpenEdge out-of-the-box?
I am looking for a job repository implementation backed by OpenEdge and recommendations regarding how to use it with OpenEdge because I have DB locking issues. One of the locking errors I get is:
org.springframework.jdbc.UncategorizedSQLException: PreparedStatementCallback; uncategorized SQLException for SQL [SELECT STEP_EXECUTION_ID, STEP_NAME, START_TIME, END_TIME, STATUS, COMMIT_COUNT, READ_COUNT, FILTER_COUNT, WRITE_COUNT, EXIT_CODE, EXIT_MESSAGE, READ_SKIP_COUNT, WRITE_SKIP_COUNT, PROCESS_SKIP_COUNT, ROLLBACK_COUNT, LAST_UPDATED, VERSION from DM_SB_STEP_EXECUTION where JOB_EXECUTION_ID = ? order by STEP_EXECUTION_ID]; SQL state [HY000]; error code [-210015]; [DataDirect][OpenEdge JDBC Driver][OpenEdge] Failure getting record lock on a record from table PUB.DM_SB_STEP_EXECUTION.; nested exception is java.sql.SQLException: [DataDirect][OpenEdge JDBC Driver][OpenEdge] Failure getting record lock on a record from table PUB.DM_SB_STEP_EXECUTION.
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:89) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:81) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:81) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.translateException(JdbcTemplate.java:1402) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:620) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:657) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:688) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:700) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:756) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.batch.core.repository.dao.JdbcStepExecutionDao.addStepExecutions(JdbcStepExecutionDao.java:299) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at com.precisionsoftware.dem.batch.config.PrecisionSimpleJobRepository.getStepExecutionCount(PrecisionSimpleJobRepository.java:261) ~[classes!/:7.1.0-0]
at org.springframework.batch.core.job.SimpleStepHandler.shouldStart(SimpleStepHandler.java:222) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at org.springframework.batch.core.job.SimpleStepHandler.handleStep(SimpleStepHandler.java:126) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at org.springframework.batch.core.job.AbstractJob.handleStep(AbstractJob.java:394) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at org.springframework.batch.core.job.SimpleJob.doExecute(SimpleJob.java:135) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at org.springframework.batch.core.job.AbstractJob.execute(AbstractJob.java:308) ~[spring-batch-core-4.0.1.RELEASE.jar!/:4.0.1.RELEASE]
at com.precisionsoftware.dem.batch.config.PrecisionJobLauncher$1.run(PrecisionJobLauncher.java:185) [classes!/:7.1.0-0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [na:1.8.0_161]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [na:1.8.0_161]
at java.lang.Thread.run(Unknown Source) [na:1.8.0_161]
Caused by: java.sql.SQLException: [DataDirect][OpenEdge JDBC Driver][OpenEdge] Failure getting record lock on a record from table PUB.DM_SB_STEP_EXECUTION.
at com.ddtek.jdbc.openedge.client.dde.ah(Unknown Source) ~[openedge-11.6.3.jar!/:na]
at com.ddtek.jdbc.openedge.client.dde.ag(Unknown Source) ~[openedge-11.6.3.jar!/:na]
at com.ddtek.jdbc.openedge.dde.a(Unknown Source) ~[openedge-11.6.3.jar!/:na]
at com.ddtek.jdbc.openedgebase.ddcq.aa(Unknown Source) ~[openedge-11.6.3.jar!/:na]
at com.ddtek.jdbc.openedgebase.dddm.next(Unknown Source) ~[openedge-11.6.3.jar!/:na]
at com.zaxxer.hikari.pool.HikariProxyResultSet.next(HikariProxyResultSet.java) ~[HikariCP-2.7.9.jar!/:na]
at org.springframework.jdbc.core.RowMapperResultSetExtractor.extractData(RowMapperResultSetExtractor.java:92) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.RowMapperResultSetExtractor.extractData(RowMapperResultSetExtractor.java:60) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate$1.doInPreparedStatement(JdbcTemplate.java:667) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:605) ~[spring-jdbc-5.0.8.RELEASE.jar!/:5.0.8.RELEASE]
... 15 common frames omitted
And below the code that creates the query that is causing issues:
public int getStepExecutionCount(JobInstance jobInstance, String stepName) {
int count = 0;
List<JobExecution> jobExecutions = jobExecutionDao.findJobExecutions(jobInstance);
for (JobExecution jobExecution : jobExecutions) {
stepExecutionDao.addStepExecutions(jobExecution);
for (StepExecution stepExecution : jobExecution.getStepExecutions()) {
if (stepName.equals(stepExecution.getStepName())) {
count++;
}
}
}
return count;
}
Spring Batch tables prefix was changed to DM_SB_

Answer 1

The performance of OpenEdge DB seems to be very poor when counting and sorting.
I have ended up changing the transactional behaviour for the Spring Batch metadata and it does not fail but do not think that is the best solution. See the XML I am importing using #ImportResource annotation.
<beans xmlns="http://www.springframework.org/schema/beans"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:context="http://www.springframework.org/schema/context"
xmlns:tx="http://www.springframework.org/schema/tx"
xmlns:aop="http://www.springframework.org/schema/aop"
xmlns:p="http://www.springframework.org/schema/p"
xsi:schemaLocation="
http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd
http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx.xsd
http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop.xsd">
<!-- Transactional configuration for Spring Batch -->
<tx:advice id="myTxAdvice" transaction-manager="springBatchTransactionManager">
<tx:attributes>
<tx:method name="create*" read-only="false" isolation="READ_COMMITTED" propagation="REQUIRES_NEW"/>
<tx:method name="getLastJobExecution*" read-only="false" isolation="READ_COMMITTED" propagation="REQUIRES_NEW"/>
<tx:method name="update*" read-only="false" isolation="READ_COMMITTED" propagation="REQUIRED"/>
<tx:method name="add*" read-only="false" isolation="READ_COMMITTED" propagation="REQUIRED"/>
<tx:method name="*" read-only="true" isolation="READ_UNCOMMITTED" propagation="REQUIRED"/>
</tx:attributes>
</tx:advice>
<aop:config>
<aop:advisor pointcut="execution(* com.company.dem.batch.config.*Repository+.*(..))" advice-ref="myTxAdvice"/>
</aop:config>