When reviewing PR on GitHub, the is a brilliant option for reviewer
to add multiple comments as pending, and then submit them to the author as a review with one notification.
Each comment has it’s own option Reply and Resolve Conversation.
E.g. if review has 10 comments, and author wants to reply for 9 of them ‘updated in commit 12345’,
reviewer will receive notifications for each of them, which can be quite annoying.
Is it possible to make pending such post-review comments and submit them as a single notification?
If not, I will submit a feature request to GitHub.
I found existing GitHub Feature request: writing PR comments in batch #1276
and posted a workaround
The problem you described is correct if an author is using main
“conversation” tab to reply to each reviewer’s comment. As a
workaround author can switch to “Files changed” tab, and there is an
option to keep all comments as “pending” and then submit all of them
at once(simulating review of own PR)
It’s definitely not intuitive, and I would appreciate if GitHub will
implement it properly for “conversation” tab
Related
Azure DevOps lets a reviewer tell the developer that they have completed their review with the "waiting for the author" flag on a PR review.
But as the developer how can I tell the reviewer "I have finished addressing comments?" They may get a notification for every reply I make to a review comment but typically, we work that a reviewer won't re-review until I've finished addressing all their comments. I can send them a message but it seems like there should be a way to do it from the PR itself.
Unfortenately there is no out-of-the-box method to do this.
These are the only subscription that can be made for code (git) notification:
You could however come up with a process flow yourself, some examples:
Define that all fixes should be made in one push to the branch. The developer can fix the remark in several commits, but whenever he pushes these commits the notification is send out - triggering the reviewer to look again.
Another option is the agreement of a code word or sentence in the commit message, like: rework-complete.
The reviewer filters out these message in their mail client, to see what PR are up for review again.
Alternatively you could alter the status of a PR linked work item.
For example:
After review, the develop work item is set back to the status: Active.
Whenever this work item is closed, the review can be done again.
This will avoid unwanted, out of AzDo, message sending.
Again, no out-of-the-box solution afaik, but I hope this helps you.
PR authors and reviewers can communicate with each other by adding and responding to PR comments. When you review a PR, use comments to point out issues with the proposed changes, suggest changes, and respond to previous comments. Aim for constructive feedback that's precise and easy to understand. Address recipients directly by using their #username. Reference work items by using #workitemID and other PRs by using !pullrequestID.
Reply to comments
PR authors should reply to comments to let the reviewers know how they're addressing feedback and suggestions:
To reply to a comment, type your response in the Write a reply field. Address recipients directly by using their #username. Reference work items by using #workitemID and other PRs by using !pullrequestID.
After entering your response, select Reply & resolve if your response is final. Otherwise, select Reply.
If you select Reply & resolve, the comment status will change to Resolved. PR authors can also directly change a comment's status, as described in the next section.
Change comment status
New comments initially have an Active status, which PR authors update during PR the review process to indicate how they addressed reviewer feedback and suggestions. PR authors can select a comment status from the status dropdown list:
Active: the default status for new comments.
Pending: the issue in this comment is under review and awaits something else.
Resolved: the issue in this comment is addressed.
Won't fix: the issue in this comment is noted but won't be fixed.
Closed: the discussion in this comment is closed.
When you have finished addressing comments, you can change all the comment status to Resolved and let the reviewers know that you have responded to their suggestions.
You can refer to this document Review and comment on pull requests - Azure Repos | Microsoft Learn.
If you want a feature to highlight that all comments have been addressed in the PR, it's recommended that you could submit a suggestion ticket on Visual Studio Feedback. That will allow you to directly interact with the appropriate engineering team and make it more convenient for the engineering team to collect and categorize your suggestions. By the way, you can directly add your vote after you create the suggestion ticket and keep track of this progress there. Voting helps increase the priority of the issue by consolidating customer impact under one feedback.
I have noticed that when you modify a comment in a Pull Request, there doesn't seem to be a way to view the history of the comment. As well, comments still allow editing after someone responds to it. One of my colleges is editing comments after he gets a response and our pull requests are not making sense because of it. Is there a history or a way to prevent changes?
Sorry but as I know it's impossible. Besides, similar issue has been submitted in this earlier suggestion ticket linked here:
Disable comment editing (i.e. add, edit, delete, and state change) in completed pull request
In addition, we can use below API to get Pull Request Thread Comments to check lastUpdatedDate and publishedDate.
GET https://dev.azure.com/{organization}/{project}/_apis/git/repositories/{repositoryId}/pullRequests/{pullRequestId}/threads/{threadId}/comments/{commentId}?api-version=5.1
Is there a way to set up a git hook to alert a developer when someone has commented on their pull request. It is frustrating that I stumble on a comment days after it has been posted
Check out the new github app in the Slack App Directory. It sends notification about almost every change on your git to Slack, including comments.
The main project for GitHub/Slack integration is github.com/integrations/slack.
It does include repository activity:
Subscribe to an Organization or a Repository On repositories, the app notifies of open, close, and re-open events on pull requests and issues in repositories you've subscribed to.
It also notifies of any push directly to the repository's default branch as well as comments on issues and pull requests.
However, regarding comments, see issue 578:
If issue is closed with a comment, the comment should be included in the Slack notification
A lot of times the final comment has some context on why the issue is being closed (e.g. fixed, duplicate, something else). If someone clicks the "comment and close" button, it seems helpful to include that comment to the "issue closed" Slack notification.
So you don't always have every comment every time.
Note: today, GitHub adds "New improvements to the Slack and GitHub integration", namely new Slack commands, but nothing regarding comments.
Does anyone know of a way in GitHub to see pull requests were I am mentioned and either I have not yet commented or commits have been added since I last commented?
If you watch a repository like this, you'll be notified by everything that happens on that particular repo:
New commits will appear on your on-site dashboard and comments on commits/issues/PRs (by the way "PR" stands for "Pull Request) as well as opened/closed/merged PRs and issues will come up both by e-mail and on your dashboard.
If I raise a Pull request and if I need to be notified by a mail saying --
You have created a Pull request for "bla bla" on "so and so" date.
On merge - I get a notification
On comment - I get a notification
So my question is...
Are there any such settings in github which sends a mail to PR creator?
Can I tag myself in the PR comment ?
Any help !!
Are there any such settings in github which sends a mail to PR creator?
There's currently no setting in GitHub that makes the platform work in that way. Note: You can send an email to support#github.com to request for such a feature.
Can I tag myself in the PR comment ?
Yes, you can. But that won't trigger an email sent to your mailbox
However, if what you're after is keeping track of your own activity on GitHub, there may exist another alternative: GitHub exposes atoms feeds for various endpoints. The user is one of them. Register your own feed in a RSS reader and you're done.
Syntax: https://github.com/{:user}.atom
Sample: https://github.com/mojombo.atom
I'm surprised that despite being up for so long, this question hasn't really been meaningfully addressed. Axibase designed a cool little tool which can do exactly what you're describing here: if a PR is raised in one of your repositories you'll be notified via email or third-party messenger service.
By default the rule will fire when anyone raises a PR, but it can be configured to only respond to specific users as that seems to be one of your requests.
The workflow here describes the underlying mechanics of the tool and this guide will take you through the entire set-up. The whole process should only take about 10 minutes from start to finish.
Disclaimer: I've worked for the team that develops ATSD, which is the database at work here.