When a user hits Resolve on a review comment I made in a PR, I would expect to see a notification in my emails but I do not seem to be getting them.
Here are the options available to me in DevOps:
Here are the options assigned to my user:
For reference, this is the section I'd expect to get updates for when set to Resolved:
I'd imagine it to work similar to how it works in GitHub. Currently I'm relying on team members to #mention me.
I am an employee of an organization. Could it be that the option has been removed from me in some group policy?
Could it be that the option has been removed from me in some group policy?
I am afraid there is no such specific settings to get the notifications for Azure DevOps PR review comment set to resolved.
We could only defined the notification for the Pull request changes. But the default and supported notifications and supported event types do not support to check the state of the PR review comment.
You could add your request for this feature on our UserVoice site (https://developercommunity.visualstudio.com/content/idea/post.html?space=21 ), which is our main forum for product suggestions. Thank you for helping us build a better Azure DevOps.
Related
After hours of googling and search, I can't find how to add a required reviewer when people of a given team create a pull request in DevOps.
Some people will be able to contribute to our repository, but they are external to our company, that's why we want to enforce this control.
Does anyone ever did it?
Thanks.
It seems that you want to conditionally set the required reviewers according to which team the pull request creator comes from. If so, I think there is no such built-in function currently provided.
Currently only the filter condition of "based on which files changed" is provided.
You could add this feature request on our UserVoice site , which is our main forum for product suggestions. After suggest raised, you can vote and add your comments for this feedback. The product team would provide the updates if they view it.
You can do this with a branch policy in Azure DevOps Repos. In ADO, go to project settings and click Repositories in the menu in the Repos section of the project settings page. Click the repository you would like to protect with code reviews and then select the Policies tab. Next select the git branch needing reviews.
On the bottom of the branch policies page you can select Automatically included reviewers. Click the + button to add reviewers. When adding the reviewers you can select if these selected reviewers are required or optional. This is actually something of a rule-builder, you can add multiple 'rules' by repeatedly going through click + and add reviewers
There is also some documentation on branch policies that might be helpful
This is my solution, this has been work for year
Azure DevOps: Automatically add different Reviewers based on Pull Request author using Microsoft Power Automate
As code reviewer with Azure DevOps you are able to leave feedback that can be marked with such statuses:
- Active: Comment is still under review.
- Pending: The issue in this comment will be addressed, but isn't fixed yet.
- Resolved: The issue brought up in this comment has been fixed.
- Won't Fix: The suggestion in the comment is noted, but won't make changes in this pull request to address it.
- Closed: Discussion for this comment is closed.
Is that possible to get notified when the status is changed? Right now I can receive notifications on new comments
We cannot get this notification, In the Azure DevOps default and supported notifications and supported event types have Changed by, Changes in folder, Code under review, Created by, Event type, Policy Bypass, Repository name, Reviewers, Source branch name, Status, Target branch name, Team project, Vote. And the comment will only Notify you about comments made to a pull request that you created or a discussion you're involved in.
This should be a good improvement, also I have helped you to submit the relevant suggestion ticket. To receive the notification about it in time, you can vote and follow this suggestion ticket.
When we create a new Pull Request in Azure DevOps, we've recently noticed that the Reviewer is Optional by default.
This has caused some confusion, as far as I recall, reviewers were always Required by default in the past.
Has this changed?
To make the Reviewer required, I know we can do this via the 'Add Required Reviewer' option but it would be nice if we could make the Reviewer Required by default...
For recent changes you may be seeing, see the this user voice request and the blog post about the new pull request experience.
One thing we've done in the past to ensure a pull request always gets a review is create teams within the project adding a set of users of which at least one will have to approve the pull request and then update the target branch policies to add the team as a required reviewer.
you can do that by using branch policies, the bit thats called add automatic reviewers: https://learn.microsoft.com/en-us/azure/devops/repos/git/branch-policies?view=azure-devops#automatically-include-code-reviewers
On my organisation we use Azure DevOps and we have a repository where we want developers to be able to create pull requests with changes to it, but only develpers belonging to certain AD group to be able to approve them. What's the best way to achieve this in Azure DevOps?
According to Microsoft Documentation there is a permission called "Contribute to pull requests " which allows "Can create, comment on, and vote on pull requests." However, disabling this would mean that people cannot create pull requests. I want them to be able to create the pull request, just not able to approve them and complete them.
However, disabling this would mean that people cannot create pull
requests. I want them to be able to create the pull request, just not
able to approve them and complete them.
If the Contribute is set to Deny, then the developer can review the code/create new branch/create PR/approve PR but can't push changes to master branch or branch not created by himself/complete PR. So this option can only partly meet your needs.
Apart from above, a most recommended way in this scenario is to use Branch Policies.
Since the original purpose is to avoid developers to complete the PR themselves, you can set both Require a minimum number of reviewers and Automatically Include reviewers options to meet your original needs:
So that all the PRs in master branch can't be completed until it gets enough approvals from specific Group. (The group you're in, Project Administrators or what) Then the developers can create the PR, but the PR can only be completed by approvals from you(Team admins/managers?).
You can choose one of the above two options or combine them together to meet your needs.
In addition: If all above still can't meet your requirements very well, feel free to post your feature request in our User Voice forum, the Product Team would consider about your feedback. Follow the feedback and you can get notifications if there's any update.
Hope all above helps :)
We are just moving from another Git-Repo-Hosting-system to Azure DevOps. In the previous system it was possible to restrict who is allowed to complete a pull request (assuming that all findings are resolved). That means the Pull request was "ready" to be merged but only specific people had the permissions to actually execute the merge.
Looking through the documentation of Azure DevOps I have not found such a feature out-of-the-box.
Did I simply miss it or it is not possible at all?
Thank you
Daniel's right. Branch policies already do exactly what you're saying. Policies enforce your team's code quality and change management standards.
You just need to use Require a minimum number of reviewers:
When the required number of reviewers approve the pull request, it can finish.
Also expand with more detail info and show you a example how will this works in your side. Image you have two teams:
Developers:
Patrick
Carl
......
[project]\PM and Developer Managers
PM and Developer Managers:
PM
Developer Managers
One could add the PM and Developer Managers: team as "required" on the branch policy, and keep the Developers team rights to pull requests, allowing other develops to still approve requests and comment etc.
But the request can't be completed until a user in PM and Developer Managers group approves it.
You're looking for branch policies. Branch policies let you designate the circumstances under which a PR can be merged, including required approvers and builds.